]> www.infradead.org Git - users/dwmw2/linux.git/commit
ASoC: amd: acp: Fix possible deadlock
authorDaniel Baluta <daniel.baluta@nxp.com>
Mon, 27 Jan 2025 08:34:22 +0000 (10:34 +0200)
committerMark Brown <broonie@kernel.org>
Mon, 27 Jan 2025 13:35:35 +0000 (13:35 +0000)
commit3ff53862c322aa7bb115d84348d5a641dc905d87
treee8a595297b2bf2183e1e7393358b220d6ce5bb40
parenteb5c79828cfa72e8dbdf2db842a781ad6806cdaf
ASoC: amd: acp: Fix possible deadlock

On error path, function acp_i2s_set_tdm_slot returns without releasing
the lock and this could result in potential deadlocks in the future.

Error reported by sparse:
sound/soc/amd/acp/acp-i2s.c:95:12: error: context imbalance in
'acp_i2s_set_tdm_slot' - different lock contexts for basic block

Fixes: cd60dec8994c ("ASoC: amd: acp: Refactor TDM slots selction based on acp revision id")
Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Link: https://patch.msgid.link/20250127083422.20406-1-daniel.baluta@nxp.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/amd/acp/acp-i2s.c