]> www.infradead.org Git - users/jedix/linux-maple.git/commit
power: supply: da9150-fg: fix potential overflow
authorAndrey Vatoropin <a.vatoropin@crpt.ru>
Thu, 30 Jan 2025 09:00:34 +0000 (09:00 +0000)
committerSebastian Reichel <sebastian.reichel@collabora.com>
Mon, 3 Feb 2025 11:23:49 +0000 (12:23 +0100)
commit3fb3cb4350befc4f901c54e0cb4a2a47b1302e08
tree9b5c9c5457bd9d9cd4a94edde5b0941365b12572
parent2014c95afecee3e76ca4a56956a936e23283f05b
power: supply: da9150-fg: fix potential overflow

Size of variable sd_gain equals four bytes - DA9150_QIF_SD_GAIN_SIZE.
Size of variable shunt_val equals two bytes - DA9150_QIF_SHUNT_VAL_SIZE.

The expression sd_gain * shunt_val is currently being evaluated using
32-bit arithmetic. So during the multiplication an overflow may occur.

As the value of type 'u64' is used as storage for the eventual result, put
ULL variable at the first position of each expression in order to give the
compiler complete information about the proper arithmetic to use. According
to C99 the guaranteed width for a variable of type 'unsigned long long' >=
64 bits.

Remove the explicit cast to u64 as it is meaningless.

Just for the sake of consistency, perform the similar trick with another
expression concerning 'iavg'.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: a419b4fd9138 ("power: Add support for DA9150 Fuel-Gauge")
Signed-off-by: Andrey Vatoropin <a.vatoropin@crpt.ru>
Link: https://lore.kernel.org/r/20250130090030.53422-1-a.vatoropin@crpt.ru
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
drivers/power/supply/da9150-fg.c