]> www.infradead.org Git - nvme.git/commit
lib/prime_numbers: KUnit test should not select PRIME_NUMBERS
authorGeert Uytterhoeven <geert@linux-m68k.org>
Mon, 14 Apr 2025 14:35:00 +0000 (16:35 +0200)
committerKees Cook <kees@kernel.org>
Tue, 15 Apr 2025 20:50:43 +0000 (13:50 -0700)
commit3f2925174f8bd811f9399cb4049f6b75fd2fba91
treed31dc87ffb7d3492316906b0fcfe94610afaddf8
parent9b044614be12d78d3a93767708b8d02fb7dfa9b0
lib/prime_numbers: KUnit test should not select PRIME_NUMBERS

Enabling a (modular) test should not silently enable additional kernel
functionality, as that may increase the attack vector of a product.

Fix this by making PRIME_NUMBERS_KUNIT_TEST depend on PRIME_NUMBERS
instead of selecting it.

After this, one can safely enable CONFIG_KUNIT_ALL_TESTS=m to build
modules for all appropriate tests for ones system, without pulling in
extra unwanted functionality, while still allowing a tester to manually
enable PRIME_NUMBERS and this test suite on a system where PRIME_NUMBERS
is not enabled by default.  Resurrect CONFIG_PRIME_NUMBERS=m in
tools/testing/selftests/lib/config for the latter use case.

Fixes: 313b38a6ecb46db4 ("lib/prime_numbers: convert self-test to KUnit")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Tamir Duberstein <tamird@gmail.com>
Link: https://lore.kernel.org/r/40f8a40eef4930d3ac9febd205bc171eb04e171c.1744641237.git.geert@linux-m68k.org
Signed-off-by: Kees Cook <kees@kernel.org>
lib/Kconfig.debug
tools/testing/selftests/lib/config