]> www.infradead.org Git - users/hch/misc.git/commit
block: protect nr_requests update using q->elevator_lock
authorNilay Shroff <nilay@linux.ibm.com>
Tue, 4 Mar 2025 10:22:34 +0000 (15:52 +0530)
committerJens Axboe <axboe@kernel.dk>
Mon, 10 Mar 2025 13:30:18 +0000 (07:30 -0600)
commit3efe7571c3ae2b6481253a2616c2bb3fbadd503b
treec3d4cfe406cc1a6b48f863e2086d468c294898eb
parent1bf70d08cc3b55abd1763e6dff5855cb8dd8318b
block: protect nr_requests update using q->elevator_lock

The sysfs attribute nr_requests could be simultaneously updated from
elevator switch/update or nr_hw_queue update code path. The update to
nr_requests for each of those code paths runs holding q->elevator_lock.
So we should protect access to sysfs attribute nr_requests using q->
elevator_lock instead of q->sysfs_lock.

Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Nilay Shroff <nilay@linux.ibm.com>
Link: https://lore.kernel.org/r/20250304102551.2533767-6-nilay@linux.ibm.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-sysfs.c
include/linux/blkdev.h