]> www.infradead.org Git - users/jedix/linux-maple.git/commit
media: v4l2-dv-timings: prevent possible overflow in v4l2_detect_gtf()
authorKarina Yankevich <k.yankevich@omp.ru>
Wed, 21 Aug 2024 11:31:34 +0000 (14:31 +0300)
committerHans Verkuil <hverkuil@xs4all.nl>
Thu, 6 Mar 2025 16:28:27 +0000 (17:28 +0100)
commit3edd1fc48d2c045e8259561797c89fe78f01717e
treee6ccc23ac0de2f786ad44454f95a53660fd56767
parent11de3582675cc0b7136e12f3971f1da3e5a05382
media: v4l2-dv-timings: prevent possible overflow in v4l2_detect_gtf()

In v4l2_detect_gtf(), it seems safer to cast the 32-bit image_width
variable to the 64-bit type u64 before multiplying to avoid
a possible overflow. The resulting object code even seems to
look better, at least on x86_64.

Found by Linux Verification Center (linuxtesting.org) with Svace.

[Sergey: rewrote the patch subject/descripition]

Fixes: c9bc9f50753d ("[media] v4l2-dv-timings: fix overflow in gtf timings calculation")
Cc: stable@vger.kernel.org
Signed-off-by: Karina Yankevich <k.yankevich@omp.ru>
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
drivers/media/v4l2-core/v4l2-dv-timings.c