]> www.infradead.org Git - users/hch/misc.git/commit
PCI/MSI: Handle the NOMASK flag correctly for all PCI/MSI backends
authorThomas Gleixner <tglx@linutronix.de>
Wed, 26 Mar 2025 12:05:35 +0000 (13:05 +0100)
committerThomas Gleixner <tglx@linutronix.de>
Wed, 26 Mar 2025 14:28:43 +0000 (15:28 +0100)
commit3ece3e8e5976c49c3f887e5923f998eabd54ff40
treefd73e37f36bb6854e79656acdd76d9ae99d4737a
parentdce3ab4c57e662ae019c22e7c2f2aa887617beae
PCI/MSI: Handle the NOMASK flag correctly for all PCI/MSI backends

The conversion of the XEN specific global variable pci_msi_ignore_mask to a
MSI domain flag, missed the facts that:

    1) Legacy architectures do not provide a interrupt domain
    2) Parent MSI domains do not necessarily have a domain info attached

Both cases result in an unconditional NULL pointer dereference. This was
unfortunatly missed in review and testing revealed it late.

Cure this by using the existing pci_msi_domain_supports() helper, which
handles all possible cases correctly.

Fixes: c3164d2e0d18 ("PCI/MSI: Convert pci_msi_ignore_mask to per MSI domain flag")
Reported-by: Daniel Gomez <da.gomez@kernel.org>
Reported-by: Borislav Petkov <bp@alien8.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Juergen Gross <jgross@suse.com>
Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
Tested-by: Borislav Petkov <bp@alien8.de>
Tested-by: Daniel Gomez <da.gomez@kernel.org>
Link: https://lore.kernel.org/all/87iknwyp2o.ffs@tglx
Closes: https://lore.kernel.org/all/qn7fzggcj6qe6r6gdbwcz23pzdz2jx64aldccmsuheabhmjgrt@tawf5nfwuvw7
drivers/pci/msi/msi.c