]> www.infradead.org Git - users/jedix/linux-maple.git/commit
s390/uv: Don't return 0 from make_hva_secure() if the operation was not successful
authorDavid Hildenbrand <david@redhat.com>
Fri, 16 May 2025 12:39:44 +0000 (14:39 +0200)
committerClaudio Imbrenda <imbrenda@linux.ibm.com>
Wed, 28 May 2025 12:13:20 +0000 (14:13 +0200)
commit3ec8a8330a1aa846dffbf1d64479213366c55b54
tree4876daec30aecd0220dd6298f01bf3fa701abd9f
parent8ffd015db85fea3e15a77027fda6c02ced4d2444
s390/uv: Don't return 0 from make_hva_secure() if the operation was not successful

If s390_wiggle_split_folio() returns 0 because splitting a large folio
succeeded, we will return 0 from make_hva_secure() even though a retry
is required. Return -EAGAIN in that case.

Otherwise, we'll return 0 from gmap_make_secure(), and consequently from
unpack_one(). In kvm_s390_pv_unpack(), we assume that unpacking
succeeded and skip unpacking this page. Later on, we run into issues
and fail booting the VM.

So far, this issue was only observed with follow-up patches where we
split large pagecache XFS folios. Maybe it can also be triggered with
shmem?

We'll cleanup s390_wiggle_split_folio() a bit next, to also return 0
if no split was required.

Fixes: d8dfda5af0be ("KVM: s390: pv: fix race when making a page secure")
Cc: stable@vger.kernel.org
Signed-off-by: David Hildenbrand <david@redhat.com>
Link: https://lore.kernel.org/r/20250516123946.1648026-2-david@redhat.com
Message-ID: <20250516123946.1648026-2-david@redhat.com>
Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
Signed-off-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
arch/s390/kernel/uv.c