]> www.infradead.org Git - linux.git/commit
bpf: Fix print_reg_state's constant scalar dump
authorDaniel Borkmann <daniel@iogearbox.net>
Wed, 16 Oct 2024 13:49:12 +0000 (15:49 +0200)
committerAndrii Nakryiko <andrii@kernel.org>
Thu, 17 Oct 2024 18:06:34 +0000 (11:06 -0700)
commit3e9e708757ca3b7eb65a820031d62fea1a265709
treed430bbb3ef23b6f94cb6f0e7574c89fb2c93cc7f
parent3878ae04e9fc24dacb77a1d32bd87e7d8108599e
bpf: Fix print_reg_state's constant scalar dump

print_reg_state() should not consider adding reg->off to reg->var_off.value
when dumping scalars. Scalars can be produced with reg->off != 0 through
BPF_ADD_CONST, and thus as-is this can skew the register log dump.

Fixes: 98d7ca374ba4 ("bpf: Track delta between "linked" registers.")
Reported-by: Nathaniel Theis <nathaniel.theis@nccgroup.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Acked-by: Andrii Nakryiko <andrii@kernel.org>
Link: https://lore.kernel.org/bpf/20241016134913.32249-2-daniel@iogearbox.net
kernel/bpf/log.c