]> www.infradead.org Git - users/jedix/linux-maple.git/commit
clk: qcom: apss-ipq-pll: drop 'alpha_en_mask' from IPQ5018 PLL config
authorGabor Juhos <j4g8y7@gmail.com>
Mon, 28 Oct 2024 18:48:15 +0000 (19:48 +0100)
committerBjorn Andersson <andersson@kernel.org>
Thu, 26 Dec 2024 22:43:03 +0000 (16:43 -0600)
commit3e632d9c33d8a4f0d8f98e69b56bd2f2145d91c4
treeb27d9922667aa5a7cc5fac9aa605cfce45ee14e2
parentd4cdb196f182d2fbe336c968228be00d8c3fed05
clk: qcom: apss-ipq-pll: drop 'alpha_en_mask' from IPQ5018 PLL config

Since neither 'alpha' nor 'alpha_hi' is defined in the configuration,
those will be initialized with zero values  implicitly. By using zero
alpha values, the output rate of the PLL will be the same whether
alpha mode is enabled or not.

Remove the superfluous initialization of the 'alpha_en_mask' member
to make it clear that enabling alpha mode is not required to get the
desired output rate.

Despite that enabling alpha mode is not needed for the initial
configuration, the set_rate() op might require that it is enabled
already. In this particular case however, the
clk_alpha_pll_stromer_set_rate() function will get reset the
ALPHA_EN bit when the PLL's rate changes, so dropping 'alpha_en_mask'
is safe.

No functional changes, the initial rate of the PLL is the same both
before and after the patch.

Tested on TP-Link Archer AX55 v1 (IPQ5018).

Signed-off-by: Gabor Juhos <j4g8y7@gmail.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20241028-alpha-mode-cleanup-v2-1-9bc6d712bd76@gmail.com
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
drivers/clk/qcom/apss-ipq-pll.c