]> www.infradead.org Git - users/jedix/linux-maple.git/commit
fbdev: omapfb: Add 'plane' value check
authorLeonid Arapov <arapovl839@gmail.com>
Tue, 18 Mar 2025 21:19:52 +0000 (21:19 +0000)
committerHelge Deller <deller@gmx.de>
Wed, 26 Mar 2025 21:39:21 +0000 (22:39 +0100)
commit3e411827f31db7f938a30a3c7a7599839401ec30
treed242872984e294f6e6e8a458077dae96e2b953d4
parentb204c29e0d8dce0cbcbec36659686a1ce7e1cbb0
fbdev: omapfb: Add 'plane' value check

Function dispc_ovl_setup is not intended to work with the value OMAP_DSS_WB
of the enum parameter plane.

The value of this parameter is initialized in dss_init_overlays and in the
current state of the code it cannot take this value so it's not a real
problem.

For the purposes of defensive coding it wouldn't be superfluous to check
the parameter value, because some functions down the call stack process
this value correctly and some not.

For example, in dispc_ovl_setup_global_alpha it may lead to buffer
overflow.

Add check for this value.

Found by Linux Verification Center (linuxtesting.org) with SVACE static
analysis tool.

Signed-off-by: Leonid Arapov <arapovl839@gmail.com>
Signed-off-by: Helge Deller <deller@gmx.de>
drivers/video/fbdev/omap2/omapfb/dss/dispc.c