]> www.infradead.org Git - users/jedix/linux-maple.git/commit
arm64: dts: mediatek: mt8195: Remove suspend-breaking reset from pcie1
authorNĂ­colas F. R. A. Prado <nfraprado@collabora.com>
Wed, 18 Dec 2024 22:01:08 +0000 (19:01 -0300)
committerAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Thu, 19 Dec 2024 12:20:22 +0000 (13:20 +0100)
commit3d7fdd8e38aafd4858935df2392762c1ab8fb40f
tree16a364ade00e3c2629a89f5d1195bda7ca4ff9de
parent312189ebb802a0242639a9c628cfdc6e532d8e11
arm64: dts: mediatek: mt8195: Remove suspend-breaking reset from pcie1

The MAC reset for PCIe port 1 on MT8195 when asserted during suspend
causes the system to hang during resume with the following error (with
no_console_suspend enabled):

  mtk-pcie-gen3 112f8000.pcie: PCIe link down, current LTSSM state: detect.quiet (0x0)
  mtk-pcie-gen3 112f8000.pcie: PM: dpm_run_callback(): genpd_resume_noirq+0x0/0x24 returns -110
  mtk-pcie-gen3 112f8000.pcie: PM: failed to resume noirq: error -110

This issue is specific to MT8195. On MT8192 with the PCIe reset,
MT8192_INFRA_RST4_PCIE_TOP_SWRST, added to the DT node, the issue is not
observed.

Since without the reset, the PCIe controller and WiFi card connected to
it, work just as well, remove the reset to allow the system to suspend
and resume properly.

Fixes: ecc0af6a3fe6 ("arm64: dts: mt8195: Add pcie and pcie phy nodes")
Signed-off-by: NĂ­colas F. R. A. Prado <nfraprado@collabora.com>
Link: https://lore.kernel.org/r/20241218-mt8195-pcie1-reset-suspend-fix-v1-1-1c021dda42a6@collabora.com
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
arch/arm64/boot/dts/mediatek/mt8195.dtsi