]> www.infradead.org Git - users/jedix/linux-maple.git/commit
printk: Fix signed integer overflow when defining LOG_BUF_LEN_MAX
authorKuan-Wei Chiu <visitorckw@gmail.com>
Sat, 28 Sep 2024 11:36:08 +0000 (19:36 +0800)
committerPetr Mladek <pmladek@suse.com>
Thu, 12 Dec 2024 09:10:03 +0000 (10:10 +0100)
commit3d6f83df8ff2d5de84b50377e4f0d45e25311c7a
treee64f31472ec3d6346a44e471aa7f2def8c4328e2
parent7d66d3ab139c8c195dbb603e21043b6e2d120fa3
printk: Fix signed integer overflow when defining LOG_BUF_LEN_MAX

Shifting 1 << 31 on a 32-bit int causes signed integer overflow, which
leads to undefined behavior. To prevent this, cast 1 to u32 before
performing the shift, ensuring well-defined behavior.

This change explicitly avoids any potential overflow by ensuring that
the shift occurs on an unsigned 32-bit integer.

Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com>
Acked-by: Petr Mladek <pmladek@suse.com>
Link: https://lore.kernel.org/r/20240928113608.1438087-1-visitorckw@gmail.com
Signed-off-by: Petr Mladek <pmladek@suse.com>
kernel/printk/printk.c