]> www.infradead.org Git - users/sagi/blktests.git/commit
Revert "Do not suppress any shellcheck warnings"
authorShin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Wed, 30 Aug 2023 10:41:34 +0000 (19:41 +0900)
committerShin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Thu, 31 Aug 2023 02:02:03 +0000 (11:02 +0900)
commit3d1c0fe2677d60f68c9ccf4912b30e77344eed04
treeb413e04c05e87655b1d80a0b2f785f4a5bace9db
parent24b9ba04c43cafd93ca8686dc706f56128268e50
Revert "Do not suppress any shellcheck warnings"

This reverts commit 26664dff17b626550fae99181112f9ceff9bb971.

The commit enabled the shellcheck warning SC2119 based on the
understanding that bash would pass arguments list "$@" from caller to
callee when functions are called without arguments. However, it was not
correct then merit of SC2119 is not so important. On the other hand,
SC2119 reports false positive warning when bash functions take optional
arguments and they are called without arguments.

Per discussion on the list [1], we concluded that the merit of optional
arguments is larger than that of SC2119. Hence, disable SC2119 again.

[1] https://lore.kernel.org/linux-nvme/o5xnqvujzakhrudv7p64owiuzgozmean6blxow4vdxhdqozg5v@qznf2tzmey7k/

Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Makefile