]> www.infradead.org Git - users/hch/xfstests-dev.git/commit
generic/204: remove unnecessary _scratch_mkfs call
authorShin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Fri, 18 Feb 2022 07:31:52 +0000 (16:31 +0900)
committerEryu Guan <guaneryu@gmail.com>
Sun, 20 Feb 2022 17:00:29 +0000 (01:00 +0800)
commit3c47d5f0d091f4aa87fd6f5a0f65fade5c463a66
treeef9355c975e5bba6a36369d66e1be68eebe1f078
parent67f9580c212dd1f2a8273f6194e686d187582255
generic/204: remove unnecessary _scratch_mkfs call

The test case generic/204 calls _scratch_mkfs to get data block size and
i-node size of the filesystem and obtained data block size is passed to
the following _scratch_mfks_sized call as an option. However, the
_scratch_mkfs call is unnecessary since the sizes can be obtained by
_scratch_mkfs_sized call without the data block size option.

Also the _scratch_mkfs call is harmful when the _scratch_mkfs succeeds
and the _scratch_mkfs_sized fails. In this case, the _scratch_mkfs
leaves valid working filesystem on scratch device then following mount
and IO operations can not detect the failure of _scratch_mkfs_sized.
This results in the test case run with unexpected test condition.

Hence, remove the _scratch_mkfs call and the data block size option for
_scratch_mkfs_sized call.

Suggested-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Eryu Guan <guaneryu@gmail.com>
tests/generic/204