]> www.infradead.org Git - users/jedix/linux-maple.git/commit
fuse: Initialize beyond-EOF page contents before setting uptodate
authorJann Horn <jannh@google.com>
Tue, 6 Aug 2024 19:51:42 +0000 (21:51 +0200)
committerLinus Torvalds <torvalds@linux-foundation.org>
Sun, 18 Aug 2024 15:45:39 +0000 (08:45 -0700)
commit3c0da3d163eb32f1f91891efaade027fa9b245b9
tree044d7125e167dff4b438d662533ac955d6dd067d
parentc3f2d783a459980eafd24c5af94ccd56a615961f
fuse: Initialize beyond-EOF page contents before setting uptodate

fuse_notify_store(), unlike fuse_do_readpage(), does not enable page
zeroing (because it can be used to change partial page contents).

So fuse_notify_store() must be more careful to fully initialize page
contents (including parts of the page that are beyond end-of-file)
before marking the page uptodate.

The current code can leave beyond-EOF page contents uninitialized, which
makes these uninitialized page contents visible to userspace via mmap().

This is an information leak, but only affects systems which do not
enable init-on-alloc (via CONFIG_INIT_ON_ALLOC_DEFAULT_ON=y or the
corresponding kernel command line parameter).

Link: https://bugs.chromium.org/p/project-zero/issues/detail?id=2574
Cc: stable@kernel.org
Fixes: a1d75f258230 ("fuse: add store request")
Signed-off-by: Jann Horn <jannh@google.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/fuse/dev.c