]> www.infradead.org Git - users/dwmw2/linux.git/commit
x86/unwind/orc: Fix unwind for newly forked tasks
authorZheng Yejian <zhengyejian@huaweicloud.com>
Fri, 13 Sep 2024 02:45:01 +0000 (10:45 +0800)
committerJosh Poimboeuf <jpoimboe@kernel.org>
Thu, 17 Oct 2024 22:13:07 +0000 (15:13 -0700)
commit3bf19a0fb690022ec22ce87a5afeb1030cbcb56c
tree4aec6e1f2b878c3e69e0a8f249860ec90919283e
parent32b504854bd96f707a03c6ddecb0af9d7fbc4775
x86/unwind/orc: Fix unwind for newly forked tasks

When arch_stack_walk_reliable() is called to unwind for newly forked
tasks, the return value is negative which means the call stack is
unreliable. This obviously does not meet expectations.

The root cause is that after commit 3aec4ecb3d1f ("x86: Rewrite
 ret_from_fork() in C"), the 'ret_addr' of newly forked task is changed
to 'ret_from_fork_asm' (see copy_thread()), then at the start of the
unwind, it is incorrectly interprets not as a "signal" one because
'ret_from_fork' is still used to determine the initial "signal" (see
__unwind_start()). Then the address gets incorrectly decremented in the
call to orc_find() (see unwind_next_frame()) and resulting in the
incorrect ORC data.

To fix it, check 'ret_from_fork_asm' rather than 'ret_from_fork' in
__unwind_start().

Fixes: 3aec4ecb3d1f ("x86: Rewrite ret_from_fork() in C")
Signed-off-by: Zheng Yejian <zhengyejian@huaweicloud.com>
Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>
arch/x86/kernel/unwind_orc.c