]> www.infradead.org Git - users/jedix/linux-maple.git/commit
btrfs: exit after state insertion failure at btrfs_convert_extent_bit()
authorFilipe Manana <fdmanana@suse.com>
Thu, 10 Apr 2025 16:11:14 +0000 (17:11 +0100)
committerDavid Sterba <dsterba@suse.com>
Thu, 15 May 2025 12:30:51 +0000 (14:30 +0200)
commit3bf179e36da917c5d9bec71c714573ed1649b7c1
tree85d41b9bb35bc629ed402db90f60646eca001975
parent2a72dd999610f9a8e2ddc0eaaf054cd66e45cde7
btrfs: exit after state insertion failure at btrfs_convert_extent_bit()

If insert_state() state failed it returns an error pointer and we call
extent_io_tree_panic() which will trigger a BUG() call. However if
CONFIG_BUG is disabled, which is an uncommon and exotic scenario, then
we fallthrough and call cache_state() which will dereference the error
pointer, resulting in an invalid memory access.

So jump to the 'out' label after calling extent_io_tree_panic(), it also
makes the code more clear besides dealing with the exotic scenario where
CONFIG_BUG is disabled.

Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/extent-io-tree.c