]> www.infradead.org Git - users/jedix/linux-maple.git/commit
PCI: endpoint: Finish virtual EP removal in pci_epf_remove_vepf()
authorZijun Hu <quic_zijuhu@quicinc.com>
Tue, 10 Dec 2024 14:00:20 +0000 (22:00 +0800)
committerBjorn Helgaas <bhelgaas@google.com>
Thu, 12 Dec 2024 19:07:19 +0000 (13:07 -0600)
commit3b9f942eb21c92041905e3943a8d5177c9a9d89d
tree7c3f64f7c99cd8f0ec503dcd918707da0a94b2e6
parente0be8511ff50bec4927ec9bc27bf0a0eea5e8f63
PCI: endpoint: Finish virtual EP removal in pci_epf_remove_vepf()

When removing a virtual Endpoint, pci_epf_remove_vepf() failed to clear
epf_vf->epf_pf, which caused a subsequent pci_epf_add_vepf() to incorrectly
return -EBUSY:

  pci_epf_add_vepf(epf_pf, epf_vf)      // add
  pci_epf_remove_vepf(epf_pf, epf_vf)   // remove
  pci_epf_add_vepf(epf_pf, epf_vf)      // add again, -EBUSY error

Fix by clearing epf_vf->epf_pf in pci_epf_remove_vepf().

Link: https://lore.kernel.org/r/20241210-pci-epc-core_fix-v3-3-4d86dd573e4b@quicinc.com
Fixes: 1cf362e907f3 ("PCI: endpoint: Add support to add virtual function in endpoint core")
Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Cc: stable@vger.kernel.org
drivers/pci/endpoint/pci-epf-core.c