]> www.infradead.org Git - users/dwmw2/linux.git/commit
media: atomisp: ssh_css: Fix a null-pointer dereference in load_video_binaries
authorZhipeng Lu <alexious@zju.edu.cn>
Thu, 18 Jan 2024 15:13:00 +0000 (16:13 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Thu, 11 Apr 2024 13:40:28 +0000 (15:40 +0200)
commit3b621e9e9e148c0928ab109ac3d4b81487469acb
tree7bef407e82e0be726e144d815dccfd49d0aa5787
parent1e1e504eeaea184ab1ca731131cbd8d614d08479
media: atomisp: ssh_css: Fix a null-pointer dereference in load_video_binaries

The allocation failure of mycs->yuv_scaler_binary in load_video_binaries()
is followed with a dereference of mycs->yuv_scaler_binary after the
following call chain:

sh_css_pipe_load_binaries()
  |-> load_video_binaries(mycs->yuv_scaler_binary == NULL)
  |
  |-> sh_css_pipe_unload_binaries()
        |-> unload_video_binaries()

In unload_video_binaries(), it calls to ia_css_binary_unload with argument
&pipe->pipe_settings.video.yuv_scaler_binary[i], which refers to the
same memory slot as mycs->yuv_scaler_binary. Thus, a null-pointer
dereference is triggered.

Link: https://lore.kernel.org/r/20240118151303.3828292-1-alexious@zju.edu.cn
Fixes: a49d25364dfb ("staging/atomisp: Add support for the Intel IPU v2")
Signed-off-by: Zhipeng Lu <alexious@zju.edu.cn>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/staging/media/atomisp/pci/sh_css.c