]> www.infradead.org Git - nvme.git/commit
PCI: cadence-ep: Fix the driver to send MSG TLP for INTx without data payload
authorHans Zhang <18255117159@163.com>
Fri, 14 Feb 2025 16:57:24 +0000 (00:57 +0800)
committerKrzysztof Wilczyński <kwilczynski@kernel.org>
Tue, 4 Mar 2025 11:22:25 +0000 (11:22 +0000)
commit3ac47fbf4f6e8c3a7c3855fac68cc3246f90f850
treeee7b363b534137c08751afb8db6346f3b8b325a7
parent2014c95afecee3e76ca4a56956a936e23283f05b
PCI: cadence-ep: Fix the driver to send MSG TLP for INTx without data payload

Per the Cadence's "PCIe Controller IP for AX14" user guide, Version
1.04, Section 9.1.7.1, "AXI Subordinate to PCIe Address Translation
Registers", Table 9.4, the bit 16 of the AXI Subordinate Address
(axi_s_awaddr) when set corresponds to MSG with data, and when not set,
to MSG without data.

However, the driver is currently doing the opposite and due to this,
the INTx is never received on the host.

So, fix the driver to reflect the documentation and also make INTx work.

Fixes: 37dddf14f1ae ("PCI: cadence: Add EndPoint Controller driver for Cadence PCIe controller")
Signed-off-by: Hans Zhang <18255117159@163.com>
Signed-off-by: Hans Zhang <hans.zhang@cixtech.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Link: https://lore.kernel.org/r/20250214165724.184599-1-18255117159@163.com
[kwilczynski: commit log]
Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org>
drivers/pci/controller/cadence/pcie-cadence-ep.c
drivers/pci/controller/cadence/pcie-cadence.h