]> www.infradead.org Git - users/jedix/linux-maple.git/commit
mailbox: pcc: Refactor error handling in irq handler into separate function
authorSudeep Holla <sudeep.holla@arm.com>
Thu, 13 Mar 2025 15:28:52 +0000 (15:28 +0000)
committerJassi Brar <jassisinghbrar@gmail.com>
Thu, 27 Mar 2025 01:58:26 +0000 (20:58 -0500)
commit3a675f50415b95f2ae10bfd932e2154ba1a08ee7
tree10935a7b56cd1fd22675b79ed1a5ec13a648f706
parentd181acea5b864e91f38f5771b8961215ce5017ae
mailbox: pcc: Refactor error handling in irq handler into separate function

The existing error handling logic in pcc_mbox_irq() is intermixed with the
main flow of the function. The command complete check and the complete
complete update/acknowledgment are nicely factored into separate functions.

Moves error detection and clearing logic into a separate function called:
pcc_mbox_error_check_and_clear() by extracting error-handling logic from
pcc_mbox_irq().

This ensures error checking and clearing are handled separately and it
improves maintainability by keeping the IRQ handler focused on processing
events.

Acked-by: Huisong Li <lihuisong@huawei.com>
Tested-by: Huisong Li <lihuisong@huawei.com>
Tested-by: Adam Young <admiyo@os.amperecomputing.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Signed-off-by: Jassi Brar <jassisinghbrar@gmail.com>
drivers/mailbox/pcc.c