]> www.infradead.org Git - users/hch/misc.git/commit
dql: Fix dql->limit value when reset.
authorJing Su <jingsusu@didiglobal.com>
Wed, 19 Mar 2025 08:57:51 +0000 (16:57 +0800)
committerJakub Kicinski <kuba@kernel.org>
Tue, 25 Mar 2025 13:26:55 +0000 (06:26 -0700)
commit3a17f23f7c36bac3a3584aaf97d3e3e0b2790396
tree4724c9753e88acb2eb2a1cad61f3941c37b1e1a9
parent45e36a8e3c17c4d50ecbc863893f253fb46ac070
dql: Fix dql->limit value when reset.

Executing dql_reset after setting a non-zero value for limit_min can
lead to an unreasonable situation where dql->limit is less than
dql->limit_min.

For instance, after setting
/sys/class/net/eth*/queues/tx-0/byte_queue_limits/limit_min,
an ifconfig down/up operation might cause the ethernet driver to call
netdev_tx_reset_queue, which in turn invokes dql_reset.

In this case, dql->limit is reset to 0 while dql->limit_min remains
non-zero value, which is unexpected. The limit should always be
greater than or equal to limit_min.

Signed-off-by: Jing Su <jingsusu@didiglobal.com>
Link: https://patch.msgid.link/Z9qHD1s/NEuQBdgH@pilot-ThinkCentre-M930t-N000
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
lib/dynamic_queue_limits.c