]> www.infradead.org Git - users/jedix/linux-maple.git/commit
spi: spi-rockchip: Fix missing unwind goto in rockchip_sfc_probe()
authorLi Lanzhe <u202212060@hust.edu.cn>
Wed, 19 Apr 2023 11:50:29 +0000 (07:50 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 26 Apr 2023 12:28:34 +0000 (14:28 +0200)
commit39eeb724c4d9a9f3295c4d26e186e8fac4aeb317
treec2e683da0b7766a1d3a659057412da5c2185a7d2
parentef018e12b1ed4e4e50aae58b75e27a23d1e03352
spi: spi-rockchip: Fix missing unwind goto in rockchip_sfc_probe()

[ Upstream commit 359f5b0d4e26b7a7bcc574d6148b31a17cefe47d ]

If devm_request_irq() fails, then we are directly return 'ret' without
clk_disable_unprepare(sfc->clk) and clk_disable_unprepare(sfc->hclk).

Fix this by changing direct return to a goto 'err_irq'.

Fixes: 0b89fc0a367e ("spi: rockchip-sfc: add rockchip serial flash controller")
Signed-off-by: Li Lanzhe <u202212060@hust.edu.cn>
Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn>
Link: https://lore.kernel.org/r/20230419115030.6029-1-u202212060@hust.edu.cn
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/spi/spi-rockchip-sfc.c