]> www.infradead.org Git - users/willy/xarray.git/commit
coredump: Only sort VMAs when core_sort_vma sysctl is set
authorKees Cook <kees@kernel.org>
Wed, 19 Feb 2025 19:53:16 +0000 (11:53 -0800)
committerKees Cook <kees@kernel.org>
Mon, 24 Feb 2025 18:51:57 +0000 (10:51 -0800)
commit39ec9eaaa165d297d008d1fa385748430bd18e4d
tree9f50f1f78fae3b6c77d123c29237bf204b69e377
parenta64dcfb451e254085a7daee5fe51bf22959d52d3
coredump: Only sort VMAs when core_sort_vma sysctl is set

The sorting of VMAs by size in commit 7d442a33bfe8 ("binfmt_elf: Dump
smaller VMAs first in ELF cores") breaks elfutils[1]. Instead, sort
based on the setting of the new sysctl, core_sort_vma, which defaults
to 0, no sorting.

Reported-by: Michael Stapelberg <michael@stapelberg.ch>
Closes: https://lore.kernel.org/all/20250218085407.61126-1-michael@stapelberg.de/ [1]
Fixes: 7d442a33bfe8 ("binfmt_elf: Dump smaller VMAs first in ELF cores")
Signed-off-by: Kees Cook <kees@kernel.org>
Documentation/admin-guide/sysctl/kernel.rst
fs/coredump.c