]> www.infradead.org Git - users/dwmw2/linux.git/commit
HID: magicmouse: Do not set BTN_MOUSE on double report
authorJosé Expósito <jose.exposito89@gmail.com>
Sun, 9 Oct 2022 18:27:47 +0000 (20:27 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 30 Oct 2022 08:41:16 +0000 (09:41 +0100)
commit39d10f0dfb7201cbd722706e0c428e4f7d89281f
tree7ac7636b7dee74412f3d208b2657f07c87269ad1
parented5baf3d0a33caaca4cd4073ebb0854cc77a616d
HID: magicmouse: Do not set BTN_MOUSE on double report

[ Upstream commit bb5f0c855dcfc893ae5ed90e4c646bde9e4498bf ]

Under certain conditions the Magic Trackpad can group 2 reports in a
single packet. The packet is split and the raw event function is
invoked recursively for each part.

However, after processing each part, the BTN_MOUSE status is updated,
sending multiple click events. [1]

Return after processing double reports to avoid this issue.

Link: https://gitlab.freedesktop.org/libinput/libinput/-/issues/811
Fixes: a462230e16ac ("HID: magicmouse: enable Magic Trackpad support")
Reported-by: Nulo <git@nulo.in>
Signed-off-by: José Expósito <jose.exposito89@gmail.com>
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Link: https://lore.kernel.org/r/20221009182747.90730-1-jose.exposito89@gmail.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/hid/hid-magicmouse.c