]> www.infradead.org Git - users/willy/xarray.git/commit
scsi: lpfc: Fix unintentional double clearing of vmid_flag
authorJustin Tee <justin.tee@broadcom.com>
Fri, 26 Jul 2024 23:15:08 +0000 (16:15 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Sat, 3 Aug 2024 01:48:05 +0000 (21:48 -0400)
commit3976beb1b410441bab9c3726e2ba76cc7a4c0b2d
tree8b5ff792f4809aa0e5592f2c8cdf25fe0fea5a20
parent2be1d4f11944cd6283cb97268b3e17c4424945ca
scsi: lpfc: Fix unintentional double clearing of vmid_flag

The vport->vmid_flag is unintentionally cleared twice after an issue_lip
via the lpfc_reinit_vmid routine().

The first call to lpfc_reinit_vmid() is in lpfc_cmpl_els_flogi().  Then
lpfc_cmpl_els_flogi_fabric() calls lpfc_register_new_vport(), which calls
lpfc_cmpl_reg_new_vport() when the mbox command completes and calls
lpfc_reinit_vmid() a second time.

Fix by moving the vmid_flag clear outside of the lpfc_reinit_vmid() routine
so that vmid_flag is only cleared once upon FLOGI completion.

Signed-off-by: Justin Tee <justin.tee@broadcom.com>
Link: https://lore.kernel.org/r/20240726231512.92867-5-justintee8345@gmail.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/lpfc/lpfc_els.c
drivers/scsi/lpfc/lpfc_vmid.c