]> www.infradead.org Git - users/dwmw2/linux.git/commit
landlock: Don't lose track of restrictions on cred_transfer
authorJann Horn <jannh@google.com>
Wed, 24 Jul 2024 12:49:01 +0000 (14:49 +0200)
committerMickaël Salaün <mic@digikod.net>
Wed, 24 Jul 2024 15:34:54 +0000 (17:34 +0200)
commit39705a6c29f8a2b93cf5b99528a55366c50014d1
tree6385b034d3c8a2ef367614b24c1e6053ca024a2a
parent0c3836482481200ead7b416ca80c68a29cfdaabd
landlock: Don't lose track of restrictions on cred_transfer

When a process' cred struct is replaced, this _almost_ always invokes
the cred_prepare LSM hook; but in one special case (when
KEYCTL_SESSION_TO_PARENT updates the parent's credentials), the
cred_transfer LSM hook is used instead.  Landlock only implements the
cred_prepare hook, not cred_transfer, so KEYCTL_SESSION_TO_PARENT causes
all information on Landlock restrictions to be lost.

This basically means that a process with the ability to use the fork()
and keyctl() syscalls can get rid of all Landlock restrictions on
itself.

Fix it by adding a cred_transfer hook that does the same thing as the
existing cred_prepare hook. (Implemented by having hook_cred_prepare()
call hook_cred_transfer() so that the two functions are less likely to
accidentally diverge in the future.)

Cc: stable@kernel.org
Fixes: 385975dca53e ("landlock: Set up the security framework and manage credentials")
Signed-off-by: Jann Horn <jannh@google.com>
Link: https://lore.kernel.org/r/20240724-landlock-houdini-fix-v1-1-df89a4560ca3@google.com
Signed-off-by: Mickaël Salaün <mic@digikod.net>
security/landlock/cred.c