]> www.infradead.org Git - users/jedix/linux-maple.git/commit
selftests/bpf: Fix kmem_cache iterator draining
authorT.J. Mercier <tjmercier@google.com>
Mon, 28 Apr 2025 18:02:54 +0000 (18:02 +0000)
committerMartin KaFai Lau <martin.lau@kernel.org>
Tue, 29 Apr 2025 20:21:48 +0000 (13:21 -0700)
commit38d976c32d85ef12dcd2b8a231196f7049548477
treeaeac99ba00700681fb794007208320acd9dcdb8b
parent8e64c387c942229c551d0f23de4d9993d3a2acb6
selftests/bpf: Fix kmem_cache iterator draining

The closing parentheses around the read syscall is misplaced, causing
single byte reads from the iterator instead of buf sized reads. While
the end result is the same, many more read calls than necessary are
performed.

$ tools/testing/selftests/bpf/vmtest.sh  "./test_progs -t kmem_cache_iter"
145/1   kmem_cache_iter/check_task_struct:OK
145/2   kmem_cache_iter/check_slabinfo:OK
145/3   kmem_cache_iter/open_coded_iter:OK
145     kmem_cache_iter:OK
Summary: 1/3 PASSED, 0 SKIPPED, 0 FAILED

Fixes: a496d0cdc84d ("selftests/bpf: Add a test for kmem_cache_iter")
Signed-off-by: T.J. Mercier <tjmercier@google.com>
Signed-off-by: Martin KaFai Lau <martin.lau@kernel.org>
Acked-by: Song Liu <song@kernel.org>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Link: https://patch.msgid.link/20250428180256.1482899-1-tjmercier@google.com
tools/testing/selftests/bpf/prog_tests/kmem_cache_iter.c