]> www.infradead.org Git - users/dwmw2/linux.git/commit
net: dsa: qca8k: replace deprecated strncpy with ethtool_sprintf
authorJustin Stitt <justinstitt@google.com>
Mon, 9 Oct 2023 18:34:45 +0000 (18:34 +0000)
committerJakub Kicinski <kuba@kernel.org>
Wed, 11 Oct 2023 02:59:09 +0000 (19:59 -0700)
commit382bb32d3865ebe34e8b11e3117a8b3a3debddd3
tree96fa6e0bdfa0f0c43487c7d0f8a8cf1d823a03a6
parent1dab47139e6118a420acec8426a860ea4b40c379
net: dsa: qca8k: replace deprecated strncpy with ethtool_sprintf

`strncpy` is deprecated for use on NUL-terminated destination strings
[1] and as such we should prefer more robust and less ambiguous string
interfaces.

ethtool_sprintf() is designed specifically for get_strings() usage.
Let's replace strncpy in favor of this more robust and easier to
understand interface.

Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings
Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html
Link: https://github.com/KSPP/linux/issues/90
Signed-off-by: Justin Stitt <justinstitt@google.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Link: https://lore.kernel.org/r/20231009-strncpy-drivers-net-dsa-qca-qca8k-common-c-v1-1-34c8040e0f32@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/dsa/qca/qca8k-common.c