]> www.infradead.org Git - users/dwmw2/linux.git/commit
net: ena: replace deprecated strncpy with strscpy
authorjustinstitt@google.com <justinstitt@google.com>
Thu, 7 Dec 2023 21:34:42 +0000 (21:34 +0000)
committerDavid S. Miller <davem@davemloft.net>
Sun, 10 Dec 2023 19:08:58 +0000 (19:08 +0000)
commit378bc9a40ed8b6f1bac558a64b65d4754de89387
tree161a1a0ca9aa9b2fe514d5500957dbbdc8764182
parenta3c205d0560f63ff02516b6d9fc3348dc34251c8
net: ena: replace deprecated strncpy with strscpy

`strncpy` is deprecated for use on NUL-terminated destination strings
[1] and as such we should prefer more robust and less ambiguous string
interfaces.

A suitable replacement is `strscpy` [2] due to the fact that it
guarantees NUL-termination on the destination buffer without
unnecessarily NUL-padding.

host_info allocation is done in ena_com_allocate_host_info() via
dma_alloc_coherent() and is not zero initialized by alloc_etherdev_mq().

However zero initialization of the destination doesn't matter in this case,
because strscpy() guarantees a NULL termination.

Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings
Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html
Link: https://github.com/KSPP/linux/issues/90
Cc: linux-hardening@vger.kernel.org
Signed-off-by: Justin Stitt <justinstitt@google.com>
Acked-by: Arthur Kiyanovski <akiyano@amazon.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/amazon/ena/ena_netdev.c