]> www.infradead.org Git - users/jedix/linux-maple.git/commit
locking/qspinlock: Always evaluate lockevent* non-event parameter once
authorWaiman Long <longman@redhat.com>
Tue, 19 Mar 2024 00:50:04 +0000 (20:50 -0400)
committerIngo Molnar <mingo@kernel.org>
Thu, 21 Mar 2024 19:45:17 +0000 (20:45 +0100)
commit3774b28d8f3b9e8a946beb9550bee85e5454fc9f
treeb7bd0cbb64f1d2e4fb10639e2dda674422752685
parent4ae3dc83b047d51485cce1a72be277a110d77c91
locking/qspinlock: Always evaluate lockevent* non-event parameter once

The 'inc' parameter of lockevent_add() and the cond parameter of
lockevent_cond_inc() are only evaluated when CONFIG_LOCK_EVENT_COUNTS
is on. That can cause problem if those parameters are expressions
with side effect like a "++". Fix this by evaluating those non-event
parameters once even if CONFIG_LOCK_EVENT_COUNTS is off. This will also
eliminate the need of the __maybe_unused attribute to the wait_early
local variable in pv_wait_node().

Suggested-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Waiman Long <longman@redhat.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Reviewed-by: Boqun Feng <boqun.feng@gmail.com>
Link: https://lore.kernel.org/r/20240319005004.1692705-1-longman@redhat.com
kernel/locking/lock_events.h
kernel/locking/qspinlock_paravirt.h