]> www.infradead.org Git - users/jedix/linux-maple.git/commit
clk: qcom: Fix missing error check for dev_pm_domain_attach()
authorWentao Liang <vulab@iscas.ac.cn>
Tue, 11 Feb 2025 09:20:17 +0000 (17:20 +0800)
committerBjorn Andersson <andersson@kernel.org>
Wed, 16 Apr 2025 02:37:39 +0000 (21:37 -0500)
commit36eb51ac8bd545b6344c05a9860e4e65ba8d7a62
treed3f05c31d0004032320ba4292ecf5ae43fda00cd
parent0af2f6be1b4281385b618cb86ad946eded089ac8
clk: qcom: Fix missing error check for dev_pm_domain_attach()

In the current implementation, the return value of dev_pm_domain_attach()
is not checked. This can lead to silent failures if the function fails,
as the code would continue execution and return 0, ignoring the error.

This patch adds a check for the return value of dev_pm_domain_attach().
If the function fails, an error message is logged using dev_err_probe(),
and the error is propagated to the existing error handling path `err`,
which ensures proper cleanup by calling clk_notifier_unregister().

Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
Link: https://lore.kernel.org/r/20250211092017.562-1-vulab@iscas.ac.cn
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
drivers/clk/qcom/apcs-sdx55.c