]> www.infradead.org Git - mtd-utils.git/commit
ubi-utils: ubirsvol: Fix integer overflow in ubirsvol.c
authorAnton Moryakov <ant.v.moryakov@gmail.com>
Tue, 10 Dec 2024 00:07:26 +0000 (03:07 +0300)
committerDavid Oberhollenzer <david.oberhollenzer@sigma-star.at>
Tue, 17 Dec 2024 13:34:18 +0000 (14:34 +0100)
commit36d1ba9ba75e45da5ff049f4a4bec4ea576a9689
tree5566e7976a8fe289504d266cc6084d2267a37d3a
parent2764911eb37dfb302d44bb5b2d5984d662b40c27
ubi-utils: ubirsvol: Fix integer overflow in ubirsvol.c

Report of the static analyzer:
The value of an arithmetic expression 'vol_info.leb_size * args.lebs' is a subject to overflow because its operands are not cast to a larger data type before performing arithmetic

Corrections explained:
The fix ensures values ​​are checked before multiplication.
Added casting vol_info.leb_size to long long

Triggers found by static analyzer Svace.

Signed-off-by: Anton Moryakov <ant.v.moryakov@gmail.com>
Reviewed-by: Zhihao Cheng <chengzhihao1@huawei.com>
Signed-off-by: David Oberhollenzer <david.oberhollenzer@sigma-star.at>
ubi-utils/ubirsvol.c