]> www.infradead.org Git - users/jedix/linux-maple.git/commit
iio: gts-helper: Fix memory leaks for the error path of iio_gts_build_avail_scale_table()
authorJinjie Ruan <ruanjinjie@huawei.com>
Wed, 16 Oct 2024 01:24:53 +0000 (09:24 +0800)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sat, 19 Oct 2024 14:10:33 +0000 (15:10 +0100)
commit369f05688911b05216cfcd6ca74473bec87948d7
treea961683a7d0f969525f582f6d2c0c7b3665f6bab
parent691e79ffc42154a9c91dc3b7e96a307037b4be74
iio: gts-helper: Fix memory leaks for the error path of iio_gts_build_avail_scale_table()

If per_time_scales[i] or per_time_gains[i] kcalloc fails in the for loop
of iio_gts_build_avail_scale_table(), the err_free_out will fail to call
kfree() each time when i is reduced to 0, so all the per_time_scales[0]
and per_time_gains[0] will not be freed, which will cause memory leaks.

Fix it by checking if i >= 0.

Cc: stable@vger.kernel.org
Fixes: 38416c28e168 ("iio: light: Add gain-time-scale helpers")
Reviewed-by: Matti Vaittinen <mazziesaccount@gmail.com>
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Link: https://patch.msgid.link/20241016012453.2013302-1-ruanjinjie@huawei.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/industrialio-gts-helper.c