]> www.infradead.org Git - users/dwmw2/linux.git/commit
ksmbd: Fix UAF in __close_file_table_ids
authorSean Heelan <seanheelan@gmail.com>
Tue, 6 May 2025 13:04:52 +0000 (22:04 +0900)
committerSteve French <stfrench@microsoft.com>
Tue, 6 May 2025 13:37:02 +0000 (08:37 -0500)
commit36991c1ccde2d5a521577c448ffe07fcccfe104d
tree9b640ecda476c5d23b085fd6839320b3fdc7d746
parent0ca6df4f40cf4c32487944aaf48319cb6c25accc
ksmbd: Fix UAF in __close_file_table_ids

A use-after-free is possible if one thread destroys the file
via __ksmbd_close_fd while another thread holds a reference to
it. The existing checks on fp->refcount are not sufficient to
prevent this.

The fix takes ft->lock around the section which removes the
file from the file table. This prevents two threads acquiring the
same file pointer via __close_file_table_ids, as well as the other
functions which retrieve a file from the IDR and which already use
this same lock.

Cc: stable@vger.kernel.org
Signed-off-by: Sean Heelan <seanheelan@gmail.com>
Acked-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/smb/server/vfs_cache.c