]> www.infradead.org Git - users/jedix/linux-maple.git/commit
nilfs2: protect access to buffers with no active references
authorRyusuke Konishi <konishi.ryusuke@gmail.com>
Tue, 7 Jan 2025 20:00:47 +0000 (05:00 +0900)
committerAndrew Morton <akpm@linux-foundation.org>
Sat, 25 Jan 2025 06:47:24 +0000 (22:47 -0800)
commit367a9bffabe08c04f6d725032cce3d891b2b9e1a
tree707fa102f669911e3ff378beeb7c12a7ba294cc1
parentca76bb226bf47ff04c782cacbd299f12ddee1ec1
nilfs2: protect access to buffers with no active references

nilfs_lookup_dirty_data_buffers(), which iterates through the buffers
attached to dirty data folios/pages, accesses the attached buffers without
locking the folios/pages.

For data cache, nilfs_clear_folio_dirty() may be called asynchronously
when the file system degenerates to read only, so
nilfs_lookup_dirty_data_buffers() still has the potential to cause use
after free issues when buffers lose the protection of their dirty state
midway due to this asynchronous clearing and are unintentionally freed by
try_to_free_buffers().

Eliminate this race issue by adjusting the lock section in this function.

Link: https://lkml.kernel.org/r/20250107200202.6432-3-konishi.ryusuke@gmail.com
Signed-off-by: Ryusuke Konishi <konishi.ryusuke@gmail.com>
Fixes: 8c26c4e2694a ("nilfs2: fix issue with flush kernel thread after remount in RO mode because of driver's internal error or metadata corruption")
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
fs/nilfs2/segment.c