]> www.infradead.org Git - users/jedix/linux-maple.git/commit
<linux/cleanup.h>: Allow the passing of both iomem and non-iomem pointers to no_free_...
authorIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Mon, 10 Mar 2025 12:21:58 +0000 (14:21 +0200)
committerIngo Molnar <mingo@kernel.org>
Mon, 10 Mar 2025 19:02:14 +0000 (20:02 +0100)
commit366fef794bd2b7c2e9df933f6828dd9739bfba84
tree0f34ba78f5bbe8f08bc9fe9dbd93d242903ac74c
parent80e54e84911a923c40d7bee33a34c1b4be148d7a
<linux/cleanup.h>: Allow the passing of both iomem and non-iomem pointers to no_free_ptr()

Calling no_free_ptr() for an __iomem pointer results in Sparse
complaining about the types:

  warning: incorrect type in argument 1 (different address spaces)
     expected void const volatile *val
     got void [noderef] __iomem *__val

[ The example is from drivers/platform/x86/intel/pmc/core_ssram.c:283 ]

The problem is caused by the signature of __must_check_fn() added in:

  85be6d842447 ("cleanup: Make no_free_ptr() __must_check")

... to enforce that the return value is always used.

Use __force to allow both iomem and non-iomem pointers to be given for
no_free_ptr().

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Dan Williams <dan.j.williams@intel.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Link: https://lore.kernel.org/r/20250310122158.20966-1-ilpo.jarvinen@linux.intel.com
Closes: https://lore.kernel.org/oe-kbuild-all/202403050547.qnZtuNlN-lkp@intel.com/
include/linux/cleanup.h