]> www.infradead.org Git - users/willy/linux.git/commit
thermal: core: Add sanity checks for polling_delay and passive_delay
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Thu, 11 Jul 2024 12:39:02 +0000 (14:39 +0200)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Fri, 12 Jul 2024 13:14:57 +0000 (15:14 +0200)
commit3669716401921c4c545ac2998d7c67f9727ee056
tree5ef501b14990c42bb78b805fae8396dccf513d4f
parent5b674baa596e624fde8bf62b9a3d8a26eef399b2
thermal: core: Add sanity checks for polling_delay and passive_delay

If polling_delay is nonzero and passive_delay is greater than
polling_delay, the thermal zone temperature will be updated less
often when tz->passive is nonzero, which is not as expected.  Make
the thermal zone registration fail with -EINVAL in that case as
this is a clear thermal zone configuration mistake.

If polling_delay is nonzero and passive_delay is 0, which is regarded
as a valid thermal zone configuration, the thermal zone will use polling
except when tz->passive is nonzero.  However, the expected behavior in
that case is to continue temperature polling with the same delay value
regardless of tz->passive, so set passive_delay to the polling_delay
value then.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://patch.msgid.link/5802156.DvuYhMxLoT@rjwysocki.net
drivers/thermal/thermal_core.c