]> www.infradead.org Git - users/jedix/linux-maple.git/commit
PCI: brcmstb: Fix error path after a call to regulator_bulk_get()
authorJim Quinlan <james.quinlan@broadcom.com>
Fri, 14 Feb 2025 17:39:32 +0000 (12:39 -0500)
committerKrzysztof Wilczyński <kwilczynski@kernel.org>
Tue, 4 Mar 2025 16:00:20 +0000 (16:00 +0000)
commit3651ad5249c51cf7eee078e12612557040a6bdb4
tree2e58009bac6e08b09da41782572de4e5efc02889
parentb5e441793e07873397622ca917517a43aa84fe44
PCI: brcmstb: Fix error path after a call to regulator_bulk_get()

If the regulator_bulk_get() returns an error and no regulators
are created, we need to set their number to zero.

If we don't do this and the PCIe link up fails, a call to the
regulator_bulk_free() will result in a kernel panic.

While at it, print the error value, as we cannot return an error
upwards as the kernel will WARN() on an error from add_bus().

Fixes: 9e6be018b263 ("PCI: brcmstb: Enable child bus device regulators from DT")
Signed-off-by: Jim Quinlan <james.quinlan@broadcom.com>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Link: https://lore.kernel.org/r/20250214173944.47506-5-james.quinlan@broadcom.com
[kwilczynski: commit log, use comma in the message to match style with
other similar messages]
Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org>
drivers/pci/controller/pcie-brcmstb.c