]> www.infradead.org Git - users/dwmw2/linux.git/commit
x86/boot/64: Fix spurious undefined reference when CONFIG_X86_5LEVEL=n, on GCC-12
authorArd Biesheuvel <ardb@kernel.org>
Mon, 9 Dec 2024 09:41:06 +0000 (10:41 +0100)
committerIngo Molnar <mingo@kernel.org>
Tue, 10 Dec 2024 10:16:32 +0000 (11:16 +0100)
commit35aafa1d41cee0d3d50164561bca34befc1d9ce3
treeda81919074da9fc60b321757f67320d6425fda89
parenta3eaa2be7004ed7ce5cf8939c660e44a15fc3665
x86/boot/64: Fix spurious undefined reference when CONFIG_X86_5LEVEL=n, on GCC-12

In __startup_64(), the bool 'la57' can only assume the 'true' value if
CONFIG_X86_5LEVEL is enabled in the build, and generally, the compiler
can make this inference at build time, and elide any references to the
symbol 'level4_kernel_pgt', which may be undefined if 'la57' is false.

As it turns out, GCC 12 gets this wrong sometimes, and gives up with a
build error:

   ld: arch/x86/kernel/head64.o: in function `__startup_64':
   head64.c:(.head.text+0xbd): undefined reference to `level4_kernel_pgt'

even though the reference is in unreachable code. Fix this by
duplicating the IS_ENABLED(CONFIG_X86_5LEVEL) in the conditional that
tests the value of 'la57'.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/20241209094105.762857-2-ardb+git@google.com
Closes: https://lore.kernel.org/oe-kbuild-all/202412060403.efD8Kgb7-lkp@intel.com/
arch/x86/kernel/head64.c