]> www.infradead.org Git - users/hch/dma-mapping.git/commit
drm/msm/dsi: fix 32-bit signed integer extension in pclk_rate calculation
authorJonathan Marek <jonathan@marek.ca>
Mon, 7 Oct 2024 05:01:49 +0000 (01:01 -0400)
committerAbhinav Kumar <quic_abhinavk@quicinc.com>
Mon, 14 Oct 2024 20:16:17 +0000 (13:16 -0700)
commit358b762400bd94db2a14a72dfcef74c7da6bd845
tree71d7d627667e31c6e2c2c8d5eec86cf588ec5ecb
parent24436a540d16ca6a523b8e5441180001c31b6b35
drm/msm/dsi: fix 32-bit signed integer extension in pclk_rate calculation

When (mode->clock * 1000) is larger than (1<<31), int to unsigned long
conversion will sign extend the int to 64 bits and the pclk_rate value
will be incorrect.

Fix this by making the result of the multiplication unsigned.

Note that above (1<<32) would still be broken and require more changes, but
its unlikely anyone will need that anytime soon.

Fixes: c4d8cfe516dc ("drm/msm/dsi: add implementation for helper functions")
Signed-off-by: Jonathan Marek <jonathan@marek.ca>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
Patchwork: https://patchwork.freedesktop.org/patch/618434/
Link: https://lore.kernel.org/r/20241007050157.26855-2-jonathan@marek.ca
Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
drivers/gpu/drm/msm/dsi/dsi_host.c