]> www.infradead.org Git - nvme.git/commit
loop: don't require ->write_iter for writable files in loop_configure
authorChristoph Hellwig <hch@lst.de>
Tue, 20 May 2025 13:54:20 +0000 (15:54 +0200)
committerJens Axboe <axboe@kernel.dk>
Tue, 20 May 2025 15:16:23 +0000 (09:16 -0600)
commit355341e4359b2d5edf0ed5e117f7e9e7a0a5dac0
tree35d8e3a0bdb0339d2d2816267d8aee6d07f3c4fa
parentdd24f87f65c957f30e605e44961d2fd53a44c780
loop: don't require ->write_iter for writable files in loop_configure

Block devices can be opened read-write even if they can't be written to
for historic reasons.  Remove the check requiring file->f_op->write_iter
when the block devices was opened in loop_configure. The call to
loop_check_backing_file just below ensures the ->write_iter is present
for backing files opened for writing, which is the only check that is
actually needed.

Fixes: f5c84eff634b ("loop: Add sanity check for read/write_iter")
Reported-by: Christian Hesse <mail@eworm.de>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20250520135420.1177312-1-hch@lst.de
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/loop.c