]> www.infradead.org Git - users/jedix/linux-maple.git/commit
ALSA: firewire-motu: fix construction of PCM frame for capture direction
authorTakashi Sakamoto <o-takashi@sakamocchi.jp>
Tue, 26 Feb 2019 04:38:37 +0000 (13:38 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 19 Mar 2019 12:13:24 +0000 (13:13 +0100)
commit34cdfe7845089d2762f7439825e582887994ecf5
treef28fbf890293788b88aa143e401e3a37ae11b099
parent18d48bd413830eb2df22d06d0573f499185d935c
ALSA: firewire-motu: fix construction of PCM frame for capture direction

commit f97a0944a72b26a2bece72516294e112a890f98a upstream.

In data blocks of common isochronous packet for MOTU devices, PCM
frames are multiplexed in a shape of '24 bit * 4 Audio Pack', described
in IEC 61883-6. The frames are not aligned to quadlet.

For capture PCM substream, ALSA firewire-motu driver constructs PCM
frames by reading data blocks byte-by-byte. However this operation
includes bug for lower byte of the PCM sample. This brings invalid
content of the PCM samples.

This commit fixes the bug.

Reported-by: Peter Sjöberg <autopeter@gmail.com>
Cc: <stable@vger.kernel.org> # v4.12+
Fixes: 4641c9394010 ("ALSA: firewire-motu: add MOTU specific protocol layer")
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/firewire/motu/amdtp-motu.c