]> www.infradead.org Git - users/dwmw2/linux.git/commit
phy: qcom: qmp-usbc: fix NULL-deref on runtime suspend
authorJohan Hovold <johan+linaro@kernel.org>
Wed, 11 Sep 2024 11:52:52 +0000 (13:52 +0200)
committerVinod Koul <vkoul@kernel.org>
Thu, 17 Oct 2024 13:03:46 +0000 (18:33 +0530)
commit34c21f94fa1e147a19b54b6adf0c93a623b70dd8
tree64e6d949c52943087f6ca0ef90109cc1273025ce
parent29240130ab77c80bea1464317ae2a5fd29c16a0c
phy: qcom: qmp-usbc: fix NULL-deref on runtime suspend

Commit 413db06c05e7 ("phy: qcom-qmp-usb: clean up probe initialisation")
removed most users of the platform device driver data from the
qcom-qmp-usb driver, but mistakenly also removed the initialisation
despite the data still being used in the runtime PM callbacks. This bug
was later reproduced when the driver was copied to create the qmp-usbc
driver.

Restore the driver data initialisation at probe to avoid a NULL-pointer
dereference on runtime suspend.

Apparently no one uses runtime PM, which currently needs to be enabled
manually through sysfs, with these drivers.

Fixes: 19281571a4d5 ("phy: qcom: qmp-usb: split USB-C PHY driver")
Cc: stable@vger.kernel.org # 6.9
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20240911115253.10920-4-johan+linaro@kernel.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/qualcomm/phy-qcom-qmp-usbc.c