]> www.infradead.org Git - users/dwmw2/linux.git/commit
HID: i2c-hid: Revert to using power commands to wake on resume
authorKenny Levinsen <kl@kl.wtf>
Tue, 19 Nov 2024 23:53:17 +0000 (00:53 +0100)
committerBenjamin Tissoires <bentiss@kernel.org>
Thu, 28 Nov 2024 10:18:14 +0000 (11:18 +0100)
commit34851431ceca1bf457d85895bd38a4e7967e2055
treedf04543b95f59090645a4d4a1aea19e09d9e26d4
parent919464deeca24e5bf13b6c8efd0b1d25cc43866f
HID: i2c-hid: Revert to using power commands to wake on resume

commit 7d6f065de37c ("HID: i2c-hid: Use address probe to wake on resume")
replaced the retry of power commands with the dummy read "bus probe" we
use on boot which accounts for a necessary delay before retry.

This made at least one Weida device (2575:0910 in an ASUS Vivobook S14)
very unhappy, as the bus probe despite being successful somehow lead to
the following power command failing so hard that the device never lets
go of the bus. This means that even retries of the power command would
fail on a timeout as the bus remains busy.

Remove the bus probe on resume and instead reintroduce retry of the
power command for wake-up purposes while respecting the newly
established wake-up retry timings.

Fixes: 7d6f065de37c ("HID: i2c-hid: Use address probe to wake on resume")
Cc: stable@vger.kernel.org
Reported-by: Michael <auslands-kv@gmx.de>
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=219440
Link: https://lore.kernel.org/r/d5acb485-7377-4139-826d-4df04d21b5ed@leemhuis.info/
Signed-off-by: Kenny Levinsen <kl@kl.wtf>
Link: https://patch.msgid.link/20241119235615.23902-1-kl@kl.wtf
Signed-off-by: Benjamin Tissoires <bentiss@kernel.org>
drivers/hid/i2c-hid/i2c-hid-core.c