]> www.infradead.org Git - users/willy/xarray.git/commit
tcp/dccp: allow a connection when sk_max_ack_backlog is zero
authorZhongqiu Duan <dzq.aishenghu0@gmail.com>
Thu, 2 Jan 2025 17:14:26 +0000 (17:14 +0000)
committerJakub Kicinski <kuba@kernel.org>
Sat, 4 Jan 2025 16:17:23 +0000 (08:17 -0800)
commit3479c7549fb1dfa7a1db4efb7347c7b8ef50de4b
tree5f268bc6a923286792ba785c3f4e151c76122fc9
parent1e9b0e1c550c42c13c111d1a31e822057232abc4
tcp/dccp: allow a connection when sk_max_ack_backlog is zero

If the backlog of listen() is set to zero, sk_acceptq_is_full() allows
one connection to be made, but inet_csk_reqsk_queue_is_full() does not.
When the net.ipv4.tcp_syncookies is zero, inet_csk_reqsk_queue_is_full()
will cause an immediate drop before the sk_acceptq_is_full() check in
tcp_conn_request(), resulting in no connection can be made.

This patch tries to keep consistent with 64a146513f8f ("[NET]: Revert
incorrect accept queue backlog changes.").

Link: https://lore.kernel.org/netdev/20250102080258.53858-1-kuniyu@amazon.com/
Fixes: ef547f2ac16b ("tcp: remove max_qlen_log")
Signed-off-by: Zhongqiu Duan <dzq.aishenghu0@gmail.com>
Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Reviewed-by: Jason Xing <kerneljasonxing@gmail.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Link: https://patch.msgid.link/20250102171426.915276-1-dzq.aishenghu0@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
include/net/inet_connection_sock.h