]> www.infradead.org Git - users/hch/misc.git/commit
codel: remove sch->q.qlen check before qdisc_tree_reduce_backlog()
authorCong Wang <xiyou.wangcong@gmail.com>
Thu, 3 Apr 2025 21:16:31 +0000 (14:16 -0700)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 8 Apr 2025 08:57:56 +0000 (10:57 +0200)
commit342debc12183b51773b3345ba267e9263bdfaaef
tree38252179638d18fb43c74823dab589f83b810b11
parenta7a15f39c682ac4268624da2abdb9114bdde96d5
codel: remove sch->q.qlen check before qdisc_tree_reduce_backlog()

After making all ->qlen_notify() callbacks idempotent, now it is safe to
remove the check of qlen!=0 from both fq_codel_dequeue() and
codel_qdisc_dequeue().

Reported-by: Gerrard Tai <gerrard.tai@starlabs.sg>
Fixes: 4b549a2ef4be ("fq_codel: Fair Queue Codel AQM")
Fixes: 76e3cc126bb2 ("codel: Controlled Delay AQM")
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20250403211636.166257-1-xiyou.wangcong@gmail.com
Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
net/sched/sch_codel.c
net/sched/sch_fq_codel.c