]> www.infradead.org Git - users/jedix/linux-maple.git/commit
sched_ext, sched/core: Don't call scx_group_set_weight() prematurely from sched_creat...
authorTejun Heo <tj@kernel.org>
Mon, 16 Jun 2025 20:13:25 +0000 (10:13 -1000)
committerTejun Heo <tj@kernel.org>
Tue, 17 Jun 2025 18:19:55 +0000 (08:19 -1000)
commit33796b91871ad4010c8188372dd1faf97cf0f1c0
treee5fc2e04c0868a5157e5a634c41b73ecb50af7f3
parentc50784e99f0e7199cdb12dbddf02229b102744ef
sched_ext, sched/core: Don't call scx_group_set_weight() prematurely from sched_create_group()

During task_group creation, sched_create_group() calls
scx_group_set_weight() with CGROUP_WEIGHT_DFL to initialize the sched_ext
portion. This is premature and ends up calling ops.cgroup_set_weight() with
an incorrect @cgrp before ops.cgroup_init() is called.

sched_create_group() should just initialize SCX related fields in the new
task_group. Fix it by factoring out scx_tg_init() from sched_init() and
making sched_create_group() call that function instead of
scx_group_set_weight().

v2: Retain CONFIG_EXT_GROUP_SCHED ifdef in sched_init() as removing it leads
    to build failures on !CONFIG_GROUP_SCHED configs.

Signed-off-by: Tejun Heo <tj@kernel.org>
Fixes: 819513666966 ("sched_ext: Add cgroup support")
Cc: stable@vger.kernel.org # v6.12+
kernel/sched/core.c
kernel/sched/ext.c
kernel/sched/ext.h