]> www.infradead.org Git - users/hch/misc.git/commit
modules: Ensure 64-bit alignment on __ksymtab_* sections
authorHelge Deller <deller@gmx.de>
Wed, 22 Nov 2023 22:18:12 +0000 (23:18 +0100)
committerLuis Chamberlain <mcgrof@kernel.org>
Sat, 19 Oct 2024 20:35:24 +0000 (13:35 -0700)
commit335de24e5e774aa94ff9551b3194fe15f52ea1d9
treea40658c6712b0b9c4557ed5f50793d4ab7e2e7f1
parent8e929cb546ee42c9a61d24fae60605e9e3192354
modules: Ensure 64-bit alignment on __ksymtab_* sections

On 64-bit architectures without CONFIG_HAVE_ARCH_PREL32_RELOCATIONS
(e.g. ppc64, ppc64le, parisc, s390x,...) the __KSYM_REF() macro stores
64-bit pointers into the __ksymtab* sections.
Make sure that those sections will be correctly aligned at module link time,
otherwise unaligned memory accesses may happen at runtime.

As per unaligned-memory-access [0] "unaligned memory accesses [...]
will not work correctly on certain platforms and will cause performance
problems on others", so fix this.

The __kcrctab* sections store 32-bit entities, so use ALIGN(4) for those.

Signed-off-by: Helge Deller <deller@gmx.de>
[mcgrof: added unaligned-memory-access justification]
Link: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/core-api/unaligned-memory-access.rst
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
scripts/module.lds.S