]> www.infradead.org Git - users/jedix/linux-maple.git/commit
storvsc: be more picky about scmnd->sc_data_direction
authorVitaly Kuznetsov <vkuznets@redhat.com>
Thu, 25 Jun 2015 16:12:11 +0000 (18:12 +0200)
committerChuck Anderson <chuck.anderson@oracle.com>
Fri, 26 Feb 2016 02:28:51 +0000 (18:28 -0800)
commit3342dc8b933bc74309ce31989b46a84366e1994f
tree04e390a1e2f159e4cdeac07f177af92cf641b4ad
parent059fd0cf779f4b43b75127320ef4c3ae3c51fde6
storvsc: be more picky about scmnd->sc_data_direction

Under the 'default' case in scmnd->sc_data_direction we have 3 options:
- DMA_NONE which we handle correctly.
- DMA_BIDIRECTIONAL which is never supposed to be set by SCSI stack.
- Garbage value.

Do WARN() and return -EINVAL in the last two cases. virtio_scsi does
BUG_ON() here but it looks like an overkill.

Reported-by: Radim Krčmář <rkrcmar@redhat.com>
Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Acked-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: James Bottomley <JBottomley@Odin.com>
(cherry picked from commit cb1cf0804fe582f8a626c3cc591cb3127536137c)

Orabug: 21886720
Signed-off-by: Jason Luo <zhangqing.luo@oracle.com>
drivers/scsi/storvsc_drv.c